Skip to content

http: should support userland Agent

Rodrigo Muino Tomonari requested to merge github/fork/fengmk2/support-userland-agent into master

https://github.com/nodejs/node/pull/10053 assert agent must be instance of http.Agent, it make userland Agents are broken. (e.g.: https://github.com/request/tunnel-agent/blob/master/index.js#L47)

I think we should keep userland Agents still can work on the future is very important.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http

Merge request reports