Skip to content

tools: remove NODE_PATH from environment for tests

Rodrigo Muino Tomonari requested to merge github/fork/Trott/ubuntu-node-path into master

Unset NODE_PATH environment variable when running tests.

On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js.

This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed.

Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.)

Refs: https://twitter.com/trott/status/835729396900061184

/cc @bengl @nodejs/testing @nodejs/build

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools test

Merge request reports