Skip to content

build: fix llvm version detection in freebsd-10

Rodrigo Muino Tomonari requested to merge github/fork/shigeki/clang_version_detect_freebsd10 into master

In FreeBSD-10, the banner of clang version start with "FreeBSD clang version" but the current configure checks /^clang version/ so that llvm_version is 0 and openssl is built with asm_obsolete.

This can be seen in the CI output of https://ci.nodejs.org/job/node-test-commit-freebsd/7417/nodes=freebsd10-64/consoleFull that 'llvm_version': 0, in the current configure output.

With this fix, the clang version banner can be checked properly in FreeBSD-10. The result of https://ci.nodejs.org/job/node-test-commit-freebsd/7419/nodes=freebsd10-64/consoleFull shows that 'llvm_version': '3.4',.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

CC: @nodejs/platform-freebsd or @nodejs/build

Merge request reports