test: fail when child died in fork-net
Previously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This PR makes it fail so at least there is more information about why this test fails.
On a side note, looks like this test is the only test that is touching the options instanceof TCP
section in net.Server.prototyp.listen
, and it is touching an undocumented API (calling net.Server.prototyp.listen
on the TCP handle directly instead of putting it in an object's handle
or _handle
) indirectly through child_process. This probably means the documented API for handles (like {handle: new TCP()}
) doesn't get any direct test coverage.
Refs: https://github.com/nodejs/node/pull/11667
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
tests and/or benchmarks are included -
commit message follows commit guidelines
Affected core subsystem(s)
test, child_process, net