v4.x backport - test: convert var->const/let in tests

I'll fix up the commit messages once the tests are passing.

Backport of #10685, I couldn't cherry-pick as it brought in hundreds of unrelated changes, so I redid the eslint --fix and manual fixup for v4.x.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test