Skip to content

inspector: proper WS URLs when bound to 0.0.0.0

Rodrigo Muino Tomonari requested to merge github/fork/eugeneo/v7.x-0.0.0.0 into v7.x-staging

JSON target list response will now return appropriate IP address for instances listening on 0.0.0.0.

Refs: https://github.com/nodejs/node/issues/11591 PR-URL: https://github.com/nodejs/node/pull/11755 Reviewed-By: James Snell jasnell@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector: IP is not obtained from the socket

This is a backport of https://github.com/nodejs/node/pull/11755. The only change is that the test now checks if common.skipIfInspectorDisabled exists before calling it.

Merge request reports