Skip to content

build: mac OBJ_DIR should point to obj.target

Rodrigo Muino Tomonari requested to merge github/fork/danbev/common.gypi-mac-OBJ_DIR into master

I think there might be an issue with the value of OBJ_DIR when using a "mac" os. The value is currently specified in common.gypi which is included by node.gyp:

'OBJ_DIR': '<(PRODUCT_DIR)/obj',

In the generated Makefile (out/Makefile) the object output directory is:

obj := $(builddir)/obj

And in the included node.target.mk we have the OBJS declared:

OBJS := \
         $(obj).target/$(TARGET)/src/async-wrap.o \
         $(obj).target/$(TARGET)/src/cares_wrap.o \

If OBJ_DIR is used in node.gyp to point to generated object files on mac they will not be found.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Merge request reports