Skip to content

deps: cherry-pick 09de996 from V8 upstream

Rodrigo Muino Tomonari requested to merge github/fork/fhinkel/i11746 into master

Original commit message:

[debugger] fix switch block source positions.

The switch statement itself is part of the switch block.
However, the source position of the statement is outside of
the block. This leads to confusion for the debugger, if the
switch block pushes a block context: the current context is
a block context, but the scope analysis based on the current
source position tells the debugger that we should be outside
the scope, so we should have the function context.

R=marja@chromium.org
BUG=v8:6085
Review-Url: https://codereview.chromium.org/2744213003
Cr-Commit-Position: refs/heads/master@{#43744}
Committed: https://chromium.googlesource.com/v8/v8/+/09de9969ccb9bc3bbd667788afad665b309d02f5

Fixes: https://github.com/nodejs/node/issues/11746

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

deps, v8

/cc @nodejs/v8

The test in https://github.com/nodejs/node/issues/11746 does not crash with this fix anymore. But since it's a V8 fix, I think we don't need an extra regression test here.

Merge request reports