Skip to content

readline: rename `deDupeHistory` option

Rodrigo Muino Tomonari requested to merge github/fork/DannyNemer/readline-ignore-history-duplicates into master

Renames options.deDupeHistory → options.removeHistoryDuplicates for readline.createInterface(options).

The option name removeHistoryDuplicates is preferable to the semantically identical name deDupeHistory because "dedupe" (short for "deduplication") is obscure and neologistic while removeHistoryDuplicates is clear, though verbose. See this comment for more.

Updates tests and documentation for this option accordingly.

Refs: https://github.com/nodejs/node/pull/2982

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

readline

Merge request reports