Skip to content

build: always use V8_ENABLE_CHECKS in debug mode

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/common-gypi-v8-checks into master

Define V8_ENABLE_CHECKS in common.gypi for the debug mode. Without this, these checks would only be present in the object files generated from the V8 build, and so for inline functions in v8.h multiple different definitions could be generated, where one definition includes the check and the other does not.

Refs: https://github.com/nodejs/node/pull/11975#discussion_r108005423

/cc @jasongin @bnoordhuis @danbev

Merge request reports