Skip to content

test: fix flaky child-process-exec-kill-throws

Rodrigo Muino Tomonari requested to merge github/fork/Trott/taco-tuesday into master

This is a fix for test-child-process-exec-kill-throws which is currently flaky on Windows.

A bug in the test was causing the child process to fail for reasons other than those intended by the test. Instead of failing for exceeding the maxBuffer setting, the test was failing because it was trying to load internal/child_process without being passed the expose-internals flag. Move that module to where only the parent process (which gets the flag) loads it.

Additionally, improve an assertion message to help debug problems like this.

Fixes: https://github.com/nodejs/node/issues/12053

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

Merge request reports