Skip to content

build: avoid passing kill empty input in Makefile

Rodrigo Muino Tomonari requested to merge github/fork/gibfahn/xargs-makefile into master

Using xargs -r on some platforms and xargs on others doesn't work, we can't guarantee whether xargs is GNU or not. Avoid the issue by only running kill if there are processes to clean.

I ran into this as I'm on macOS, but have a GNU xargs (from brew install findutils).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

cc/ @trott @nodejs/build

EDIT: CI: https://ci.nodejs.org/job/node-test-commit/8825/ - CI is green

Merge request reports