Skip to content

n-api: Update property attrs enum to match JS spec

Rodrigo Muino Tomonari requested to merge github/fork/jasongin/napi_property_attributes into master

The napi_property_attributes enum used names and values from v8::PropertyAttribute, but those negative flag names were outdated along with the default behavior of a property being writable, enumerable, and configurable unless otherwise specified. To match the ES5 standard property descriptor those attributes should be positive flags and should default to false unless otherwise specified.

Fixes: https://github.com/nodejs/abi-stable-node/issues/221

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

N-API

Merge request reports