Skip to content

src: only block SIGUSR1 when HAVE_INSPECTOR

Rodrigo Muino Tomonari requested to merge github/fork/danbev/test-signal-handler-failure into master

I'm currently seeing a timeout error for test-signal-handler.js on macosx when using the following configuration:

./configure --debug --without-ssl && make -j8 test

--without-ssl implies that there will be no inspector but the signal SIGUSR1 is blocked in PlatformInit just the same. But in this case never unblocked which is causing the signal to never be delivered to the handlers in test-signal-handler.js and it loops until it times out.

Not sure if this is the best way of fixing this but hopefully more eyes on this will help.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Merge request reports