Skip to content

build: run cpplint even if jslint failed

Rodrigo Muino Tomonari requested to merge github/fork/krydos/continues-lint into master

As it mentioned in #12082 (closed) issue, it would be good to execute cpplint even if jslint failed. As far as I can see it should help to get both lint errors from both checks at once, which is good.

as @mscdex mentioned in the issue, there is vcbuild.bat that should be updated also with something similar, but I have huuuuge troubles with it. Could somebody help me please with this file or point me to the correct direction. I see that I can check the %errorlevel%variable but currently I do not see the way how can I pass it from cpplint to jslint "target".

Thank you

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Merge request reports