Skip to content

buffer: use slightly faster NaN check

Rodrigo Muino Tomonari requested to merge github/fork/mscdex/buffer-faster-isnan into master

Performance results:

                                                       improvement confidence      p.value
 buffers/buffer-indexof-number.js n=10000000 value=64      3.59 %        *** 5.794893e-21
 buffers/buffer-slice.js n=8192 type="fast"                6.66 %        *** 1.325662e-23
 buffers/buffer-slice.js n=8192 type="slow"                7.45 %        *** 5.384460e-23

CI: https://ci.nodejs.org/job/node-test-pull-request/7287/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • buffer

Merge request reports