Skip to content

test: initialize platform in NodeTestFixture

Rodrigo Muino Tomonari requested to merge github/fork/sam-github/initialize-platform-in-cctest into master

Calling TearDown() without Setup() first is not allowed, but this should fix a coverity warning:

*** CID 166971:  Uninitialized members  (UNINIT_CTOR)
/test/cctest/node_test_fixture.h: 97 in NodeTestFixture::NodeTestFixture()()
91         v8::V8::ShutdownPlatform();
92         delete platform_;
93         platform_ = nullptr;
94       }
95
96      private:
>>>     CID 166971:  Uninitialized members  (UNINIT_CTOR)
>>>     The compiler-generated constructor for this class does not initialize "platform_".
97       v8::Platform* platform_;
98     };
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports