Skip to content

backport: 11665 to v7

Rodrigo Muino Tomonari requested to merge github/fork/mscdex/backport-v7-11665 into v7.x-staging

This is a backport of https://github.com/nodejs/node/pull/11665 + a few non-semver-major changes (specifically only to fs.realpathSync() and fs.realpath()) from https://github.com/nodejs/node/pull/10789.

https://github.com/nodejs/node/pull/11665 was initially labeled as semver-major by me as I typically like to err on the side of caution because of the nature of some of the changes. However, some have expressed interest in downgrading it to a semver-minor to allow (a more straightforward backport of) a necessary fix for a discrepancy that exists currently in v7.x because of the way fs.Stats values are generated for fs.stat() vs fs.statSync() for example.

Landing this should fix the issue described in https://github.com/nodejs/node/issues/12419.

/cc @nodejs/ctc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • fs

Merge request reports