Skip to content

win,node-gyp: make delay-load hook optional

Rodrigo Muino Tomonari requested to merge github/fork/piscisaureus/hook-optional into v1.x

The delay-load hook that was supposed to make compiled addons work on Windows regardless of the iojs.exe/node.exe filename causes issues with a small amount of compiled addons.

It seems a bit irresponsible to land it as part of a patch release.

Therefore this patch makes it an opt-in feature. An addon may set the 'win_delay_load_hook' option to 'true' in its binding.gyp to enable this feature.

Example:

{
  'targets': [
    {
      'target_name': 'ernie',
      'win_delay_load_hook': 'true',
      ...

R=@rvagg (FYI as the release Meister) R=@am11 (could you test this with node-sass?) R=@bnoordhuis, @TooTallNate

Merge request reports