Skip to content

test: ignore spurious 'EMFILE'

Rodrigo Muino Tomonari requested to merge github/fork/refack/more-for-10286 into master

As discussed in most recently on #10286 (closed) test/parallel/test-child-process-fork-regr-gh-2847.js is a little flaky Last sighting was

c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vcbt2015\label\win10\test\parallel\test-child-process-fork-regr-gh-2847.js:61
            throw err;
            ^

Error: write EMFILE
    at exports._errnoException (util.js:1026:11)
    at ChildProcess.target._send (internal/child_process.js:663:20)
    at ChildProcess.target.send (internal/child_process.js:547:19)
    at Worker.send (internal/cluster/worker.js:54:28)
    at Socket.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vcbt2015\label\win10\test\parallel\test-child-process-fork-regr-gh-2847.js:33:14)
    at Object.onceWrapper (events.js:312:19)
    at emitNone (events.js:105:13)
    at Socket.emit (events.js:207:7)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1102:10)

Possible explanation https://github.com/nodejs/node/issues/3635#issuecomment-157714683 So as a follow up to #5422 I suggest we also ignore EMFILE raised from the connection.

Ref: #3635 (closed) Ref: #5178 Ref: #5179 Ref: #4005 Ref: #5121 Ref: #5422 Ref: https://github.com/nodejs/node/pull/12621#issuecomment-297701459 Fixes: #10286 (closed)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports