Skip to content

test: make common.noop a getter

Rodrigo Muino Tomonari requested to merge github/fork/aqrln/test-noop-getter into master

Make common.noop a getter that returns a new function object each time the propery is read, not the same one. The old behavior could possibly lead to subtle and hard to catch bugs in some cases.

Refs: https://github.com/nodejs/node/pull/12711#discussion_r114008771

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports