Skip to content

test: reduce string concatenations

Rodrigo Muino Tomonari requested to merge github/fork/vsemozhetbyt/test-templates into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Refs: https://github.com/nodejs/node/pull/12455

This is not an exhaustive deliverance from all string concatenations: if a result looked too ugly and messy, I've abstained to change, so some concatenations still remain. I am not sure if we should to add prefer-template: error to test .eslintrc.yaml, so I've also abstained from proposing, but let me know if this is discussable.

Concerning reviews: https://github.com/nodejs/node/pull/12735#issuecomment-298996435

  • 01. test: reduce string concatenations (the base commit, with test/common.js only)
  • 02. fixup: addons – known_issues, pseudo-tty
  • 03. fixup: pummel
  • 04. fixup: sequential
  • 05. fixup: parallel/assert* – child-process*
  • 06. fixup: parallel/cli* – cwd*
  • 07. fixup: parallel/dgram* – file*
  • 08. fixup: parallel/fs*
  • 09. fixup: parallel/http* – http-full-response
  • 10. fixup: parallel/http-get-pipeline-problem – http-write-empty-string!
  • 11. fixup: parallel/https* – https-drain
  • 12. fixup: parallel/https-eof-for-eom – https-truncate
  • 13. fixup: parallel/intl* – net*
  • 14. fixup: parallel/next-tick* – regress*
  • 15. fixup: parallel/repl* – spawn*
  • 16. fixup: parallel/stdin* – timers*
  • 17. fixup: parallel/tls* – tls-connect*
  • 18. fixup: parallel/tls-delayed* – tls-invoke-queued
  • 19. fixup: parallel/tls-js-stream – tls-securepair*
  • 20. fixup: parallel/tls-server* – tls-wrap-timeout
  • 21. fixup: parallel/url* – zlib*

Merge request reports