Skip to content

assert: restore TypeError if no arguments

Rodrigo Muino Tomonari requested to merge github/fork/Trott/full-assert-coverage into master

In Node 7.x, calling throw new assert.AssertionError() resulted in a TypeError.

In current master, the same call does not result in an error but, due to the default option, it results in uninformative output ("undefined undefined undefined").

This change removes the default argument, restoring a TypeError if there is no argument. This also will restore our test coverage to 100%. (The default argument is not tested in our current test suite.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

assert

Merge request reports