Skip to content

Revert "net: remove unnecessary process.nextTick()"

Rodrigo Muino Tomonari requested to merge github/fork/evanlucas/revertnet into master

This reverts commit 571882c5.

Removing the process.nextTick() call can prevent the consumer from being able to catch error events.

Looks like we ran into this before in https://github.com/nodejs/node/commit/af249fa8a15bad8996187e73b480b30dcd881bad

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

/cc @bnoordhuis

Merge request reports

Loading