Skip to content

fix wrong hash results on Windows with some CPUs that support Intel SHA Extension

Rodrigo Muino Tomonari requested to merge github/fork/shigeki/GH12691 into master
Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [x ] commit message follows commit guidelines
Affected core subsystem(s)

openssl

This PR fixes wrong hash results on Windows with some CPUs that support Intel SHA Extension and resolves the issue of TLS connection errors.

The same issue was reported to the upstream in https://github.com/openssl/openssl/issues/3241 and fixed in https://github.com/openssl/openssl/pull/3385.

This PR has the cherry-pick of the fix and asm files are updated.

This fix has already confirmed by the issue reporter in https://github.com/nodejs/node/issues/12691#issuecomment-299793715 because the issue can be reproduced on only limited CPU.

Fixes: #12691 (closed)

CC: @nodejs/crypto

Merge request reports