Skip to content

http,https: avoid instanceof for WHATWG URL

Rodrigo Muino Tomonari requested to merge github/fork/mscdex/http-client-avoid-instanceof-url into master

Benchmark results:

                                                 improvement confidence      p.value
 http/create-clientrequest.js n=1000000 len=1        7.01 %        *** 1.281605e-08
 http/create-clientrequest.js n=1000000 len=128      4.02 %        *** 6.564820e-04
 http/create-clientrequest.js n=1000000 len=16       6.01 %        *** 8.660607e-07
 http/create-clientrequest.js n=1000000 len=32       5.68 %        *** 9.863084e-06
 http/create-clientrequest.js n=1000000 len=64       6.97 %        *** 9.791414e-10
 http/create-clientrequest.js n=1000000 len=8        7.65 %        *** 1.141693e-09

CI: https://ci.nodejs.org/job/node-test-pull-request/8025/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • http
  • https

Merge request reports