Skip to content

src: fix --abort_on_uncaught_exception arg parsing

Rodrigo Muino Tomonari requested to merge github/fork/sam-github/fix-abort-on-uncaught-exception into master

Fix c0bde73f, which inadvertently introduced a use of strcmp() without correctly comparing its return to zero. Caught by coverity:

    >>>     CID 169223:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
    >>>     The "or" condition "strcmp(arg, "--abort-on-uncaught-exception") || strcmp(arg, "--abort_on_uncaught_exception")" will always be true because "arg" cannot be equal to two different values at the same time, so it must be not equal to at least one of them.
    3909         } else if (strcmp(arg, "--abort-on-uncaught-exception") ||
    3910                    strcmp(arg, "--abort_on_uncaught_exception")) {
    3911           abort_on_uncaught_exception = true;
    3912           // Also a V8 option.  Pass through as-is.
    3913           new_v8_argv[new_v8_argc] = arg;
    3914           new_v8_argc += 1;

See: https://github.com/nodejs/node/pull/12892/files#r116055631

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Merge request reports