Skip to content

buffer: fix indexOf for empty searches

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/buffer-indexof-emptystring into master

Make searches for empty subsequences return 0 for buffer.indexOf() and buffer.length for buffer.lastIndexOf(), because those are the indices of the first and last occurrence of an empty subsequence, respectively.

Make searches for empty subsequences do exactly what String.prototype.indexOf() does.

Fixes: https://github.com/nodejs/node/issues/13023

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

buffer

/cc @nodejs/buffer and because people might to consider this a semver-major change (I would not) @nodejs/ctc

CI: https://ci.nodejs.org/job/node-test-commit/9880/

Merge request reports