Skip to content

test: Improve N-API test coverage

Rodrigo Muino Tomonari requested to merge github/fork/mhdawson/napi-cov5 into master
  • add coverage for napi_get_prototype
  • add coverage for napi_strict_equals

Continue to chip away at missing coverage in my spare time.

Instead of creating addons for each of these I combined them into test_general as they did not seem naturally group with other functions. I was thinking that we want less rather than more test addons, as each one adds to the overall build time. If there is general agreement with that I might move some of the other existing tests into test_general in cases were there is only 1 or 2 functions being tested in the existing grouping.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]
Affected core subsystem(s)

test, n-api

Merge request reports