Skip to content

test: improve net-immediate-finish-test

Rodrigo Muino Tomonari requested to merge github/fork/refack/12996 into master

this tests need to fail, it's more "sanitary" to run it in /sequential/ added comment why it's ok to use common.PORT

Ref: https://github.com/nodejs/node/pull/12996 Ref: https://github.com/nodejs/node/issues/12376 Ref: https://github.com/nodejs/node/issues/12950 Ref: https://github.com/nodejs/node/issues/12951 Ref: https://github.com/nodejs/node/issues/13055 Ref: https://github.com/nodejs/node/pull/12964

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added (inline comment in test)
  • commit message follows commit guidelines
Affected core subsystem(s)

test,net

Merge request reports

Loading