Skip to content

src, async_hooks: add triggerId param to before async_hook

Rodrigo Muino Tomonari requested to merge github/fork/joshgav/add-triggerid-hooks-before into master
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

It's not clear to me whether the async_hooks before hook is supposed to receive both an async_id and a trigger_id (parent async_id), so I plumbed both all the way through in this PR to start a discussion. According to the original Node-EP only an async_id is passed, but the trigger_id is available and used in some calls already. Is there a use for it? What is the use in the init hook?

If we are to accept this, could someone help me add a better test? Thanks!

Merge request reports