Skip to content

n-api: Retain last code when getting error info

Rodrigo Muino Tomonari requested to merge github/fork/jasongin/last_error into master

Unlike most N-API functions, napi_get_last_error_info() should not clear the last error code when successful, because a pointer to (not a copy of) the error info structure is returned via an out parameter.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

Merge request reports