Skip to content

crypto: remove root_cert_store from node_crypto.h

Rodrigo Muino Tomonari requested to merge github/fork/danbev/remove-extern-root_cert_store into master

root_cert_store is defined as extern in node_crypto.h but only used in node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all be accessing the same X509_STORE through the root_cert_store pointer as far as I can tell. Am I missing something here?

This commit suggests removing it from the header and making it static in node_crypto.cc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

Merge request reports