Skip to content

vm: remove CopyProperties()- code review

This patch removes the CP() function, replacing callbacks with ones that allow the ES6 syntax.

This is a code review patch and it is not meant to land yet for 2 reasons:

  1. It works for named properties and temporarily breaks setting indexed properties. This is done on purpose for easier revision. Including the latter mirrors this code closely, thus will be an extension of this patch.
  2. It uses V8 API changes, which are under revision https://codereview.chromium.org/2807333003/,

Changes included:

  • Extend NamedPropertyHandlerConfiguration with PropertyDescriptorCallback and PropertyDefinerCallback to query ES6 property descriptors and use DefineProperty() API. (remove Query callback, which becomes the Descriptor).
  • CopyProperties() is removed and not called anymore in RunInContext().
  • A number of tests can be moved from /known_issues to /parallel.
  • V8 API extension code (which IMHO can be ignored as it is being reviewed elsewhere).
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

vm

Merge request reports

Loading