Skip to content

test: fix flaky test-tls-socket-close

Rodrigo Muino Tomonari requested to merge github/fork/Trott/reset-your-expectations-is-not-as-funny-as-i-wish-it-was into master

Add error listener to ignore ECONNRESET. Makes test reliable while it still segfaults (as expected) on Node.js 7.7.3. It might not be possible to eliminate the probable race causing ECONNRESET without also eliminating the required segfault-inducing part of the test. (Or maybe it's totally possible. If you figure it out, hey cool, submit a pull request.)

Fixes: https://github.com/nodejs/node/issues/13184

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test tls

Merge request reports