Skip to content

test: move common.PORT debug tests to sequential

Rodrigo Muino Tomonari requested to merge github/fork/gibfahn/seq-debug-sig into v6.x-staging

They tend to hang if they happen to run in parallel with another test that uses common.PORT.

I missed these when looking at https://github.com/nodejs/node/pull/13580, looks like two of these tests were competing with each other in the last run I did.

I've done a diff against the list in https://github.com/nodejs/node/issues/12376, and these are the parallel debugger tests that contain common.PORT and are no longer in master:

  • test-debug-brk-no-arg.js
  • test-debug-brk.js (https://github.com/nodejs/node/pull/13580)
  • test-debug-no-context.js
  • test-debug-port-cluster.js
  • test-debug-port-from-cmdline.js
  • test-debug-port-numbers.js
  • test-debug-signal-cluster.js
  • test-debugger-util-regression.js
grep results: 
➜  parallel git:(v6.x-staging) ❯ rg common.PORT `fnd test-debug`                                        ~/wrk/com/node/test/parallel
test-debug-no-context.js
7:const args = ['--debug', `--debug-port=${common.PORT}`, '--interactive'];

test-debug-brk-no-arg.js
6:const child = spawn(process.execPath, ['--debug-brk=' + common.PORT, '-i']);

test-debug-port-cluster.js
6:const PORT_MIN = common.PORT + 1;  // The fixture uses common.PORT.

test-debug-signal-cluster.js
8:const port = common.PORT;

test-debug-brk.js
18:    const procArgs = [`--debug-brk=${common.PORT}`].concat(extraArgs);
25:        const agentArgs = ['debug', `localhost:${common.PORT}`];

test-debug-port-from-cmdline.js
6:const debugPort = common.PORT;

test-debug-port-numbers.js
16:  const port = common.PORT + i;

test-debugger-util-regression.js
16:  `--port=${common.PORT}`,
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports