Skip to content

Fixed cluster inspect port logic

Rodrigo Muino Tomonari requested to merge github/fork/mutantcornholio/cluster-inspect into master

This is first PR mentioned in https://github.com/nodejs/node/pull/9659#issuecomment-307211154

Turned out, instead of parsing execArgv and deciding what port to use, we could just add --inspect-port to whatever port we calculated (thanks, @sam-github). I've exported initial debug options to process._debugOptions, but I need it only in tests for now.

To test new cases (different host:port variations), I wrote new test suite inspector/test-inspector-port-cluster.js and deleted parallel/test-cluster-inspector-debug-port.js in favor of it. cluster.setupMaster wasn't sufficient, I had actually start master process with debug arguments. (parallel/test-cluster-inspector-debug-port.js was still passing at the moment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • cluster

cc/ @refack @sam-github @trott @bnoordhuis @cjihrig

Merge request reports