Skip to content

test: make test-http(s)-set-timeout-server alike (2)

Rodrigo Muino Tomonari requested to merge github/fork/jklepatch/harmonize_test_http_https_set_timeout_server_2 into master

Make test-http(s)-set-timeout-server tests more similar and resolve the following issues:

  • test-http-set-timeout-server.js was missing the check to if (!common.hasCrypto()).

  • test-https-set-timeout-server.js was missing some assert statements, including with http module

  • Both files were missing some calls to common.mustCall()

  • Both files were calling createServer() in different ways

Fixes: #13588 (closed) Refs: #13625

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports