Skip to content

test: refactor test-http(s)-set-timeout-server

Rodrigo Muino Tomonari requested to merge github/fork/aqrln/refactor-test-http-set-timeout-server into master

  • Make changes to test-https-set-timeout-server to resolve inconsistencies with its http counterpart:

    • Apply the changes analogous to those in GH-13802 to the https test.
    • Add a missing common.mustCall() wrapper.
    • Make small stylistic changes (e.g., remove unnecessary line breaks in comments) to make it visually consistent with the http test.

  • Use arrow functions.

Refs: https://github.com/nodejs/node/pull/13802 Refs: https://github.com/nodejs/node/pull/13625 Refs: https://github.com/nodejs/node/pull/13822 Fixes: https://github.com/nodejs/node/issues/13588

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports