Skip to content

v8: fix process.abort() interaction with V8

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/process-abort-v859 into master

Since V8 5.9 V8 installs a default signal handler for some signals when creating a default platform instance that prints a stack trace.

However, Node already does the same thing, so it would seem like the two different stack traces would be printed; also, the V8 handler would lead to a SIGSEGV under some circumstances, rather than letting the abort continue normally.

Fixes: https://github.com/nodejs/node/issues/13865

@nodejs/v8 I don’t have the time to deal with any upstream concerns regarding this, and probably not to look into the segfault as well, so if we want to report it/have that V8 change reverted, somebody else needs to do it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

CI: https://ci.nodejs.org/job/node-test-pull-request/8862/

Merge request reports