Skip to content

Revert "test: common.expectsError should be a must call"

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/revert-14088 into master

This reverts commit 1b2733f2. (https://github.com/nodejs/node/pull/14088)

Using common.expectsError() should not necessarily require common.mustCall() and this changes unnecessarily breaks a number of test cases in the nodejs/http2 repo. There are better ways of doing this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Merge request reports