[v8.x backport] test: remove common.noop
Backport of https://github.com/nodejs/node/pull/12822.
This change removes common.noop
from the Node.js internal testing
common module.
Over the last few weeks, I've grown to dislike the common.noop
abstraction.
First, new (and experienced) contributors are unaware of it and so it results in a large number of low-value nits on PRs. It also increases the number of things newcomers and infrequent contributors have to be aware of to be effective on the project.
Second, it is confusing. Is it a singleton/property or a getter? Which should be expected? This can lead to subtle and hard-to-find bugs. (To my knowledge, none have landed on master. But I also think it's only a matter of time.)
Third, the abstraction is low-value in my opinion. What does it really get us? A case could me made that it is without value at all.
Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. common.noop
doesn't save anything over () => {}
.
So, I propose removing it.
PR-URL: https://github.com/nodejs/node/pull/12822 Reviewed-By: Teddy Katz teddy.katz@gmail.com Reviewed-By: Timothy Gu timothygu99@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: Gibson Fahnestock gibfahn@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Refael Ackermann refack@gmail.com
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
commit message follows commit guidelines
Affected core subsystem(s)
test