Skip to content

net: support passing null to listen()

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/14205 into master

This commit fixes a regression around the handling of null as the port passed to Server#listen(). With this commit, null, undefined, and 0 have the same behavior, which was the case in Node 4.

Fixes: https://github.com/nodejs/node/issues/14205

R= @sam-github @evanlucas

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

net

Merge request reports

Loading