Skip to content

test: allow inspector to reopen with same port

Rodrigo Muino Tomonari requested to merge github/fork/gibfahn/flake-inspector-open into master

Test checks that if you open the inspector with '0' (pick a random free port), close it, then reopen it, you get a different port. However this isn't necessarily true.

Fixes: https://github.com/nodejs/node/issues/14316

Refs: https://github.com/nodejs/node/issues/14316#issuecomment-315680755

So this assertion checks that when you close and reopen you don't get the same port. However AIUI node just picks a free port, so there is a (very small) chance you'll get the same port.

cc/ @sam-github as you wrote the original test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, inspector

Merge request reports