Skip to content

http: disable OutgoingMessage pipe method

Rodrigo Muino Tomonari requested to merge github/fork/Kasher/disable_pipe_outgoing_message into master

OutgoingMessage should be a write-only stream, and it shouldn't be piped. This commit disables the pipe method by throwing an exception (if this method is called).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http

Additional data

As was suggested here: https://github.com/nodejs/node/pull/14024, I disabled the use of the method pipe in OutgoingMessage. OutgoingMessage should be write-only, and shouldn't be piped.

Merge request reports