Skip to content

test: support odd value for kStringMaxLength

Rodrigo Muino Tomonari requested to merge github/fork/targos/fix-string-test-canary into master

V8 6.2 will support a larger maximum string length on 64-bit platforms. Update the test to take into account its odd value ((1 << 30) - 1 - 24).

Refs: https://github.com/v8/v8/commit/e8c9649e2570c7e278e70a6584738a3c3f828b2b Example failing test on canary: https://ci.nodejs.org/job/node-test-commit-linux/11406/nodes=centos7-64/console

@nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

buffer, V8

Merge request reports