Skip to content

deps: cherry-pick 4229ca2 from V8 upstream

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/jaimecb-cp-v8-4229ca2 into master

Running the profiler processor (--prof-process) with a profiler output file generated on Windows (with --prof) results in "UNKNOWN" code dominating the statistics. This is caused by the processor not correctly parsing the output of the "%p" format specifier on Windows.

This PR cherry-picks the upstream commit https://github.com/v8/v8/commit/4229ca207e1d139d57cd9c2e72c6174d4c81878c , that makes the output format be the same on Windows so it can be correctly parsed by --prof-process.

Original commit message: [profiler] Fix logging addresses on Windows.

Change-Id: Iff0dcec95d04b85d31a452fed31b1500ad17a9f0 Reviewed-on: https://chromium-review.googlesource.com/591373 Commit-Queue: Jaroslav Sevcik jarin@chromium.org Reviewed-by: Camillo Bruni cbruni@chromium.org Cr-Commit-Position: refs/heads/master@{#46976}

Fixes: https://github.com/nodejs/node/issues/8221 Refs: https://github.com/v8/v8/commit/4229ca207e1d139d57cd9c2e72c6174d4c81878c Refs: https://github.com/nodejs/node/pull/14510

/cc @nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps,v8,win

Merge request reports