Skip to content

src: properly manage timer in cares ChannelWrap

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/cares-fix-timer into master

This fixes a bug introduced in 727b2911 where code managing the uv_timer_t for a ChannelWrap instance was left unchanged, when it should have changed the lifetime of the handle to being tied to the ChannelWrap instance’s lifetime.

Fixes: https://github.com/nodejs/node/issues/14599 Ref: https://github.com/nodejs/node/pull/14518

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included (eeeeh … in the form of an existing test that was flaky)
  • commit message follows commit guidelines
Affected core subsystem(s)

src/cares_wrap

Merge request reports