Skip to content

[v8.x backport] test: add block scoping to test-readline-interface

Rodrigo Muino Tomonari requested to merge github/fork/Trott/backport-14615 into v8.x-staging

Use block-scoping in test-readline-interface to avoid side effects and make tests more modular. (Some contain race conditions and will need to be moved to the sequential directory if they can't be refactored to avoid the race condition.)

PR-URL: https://github.com/nodejs/node/pull/14615 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Yuta Hiroto hello@about-hiroppy.com Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports