Skip to content

src: use local isolate instead of args.GetIsolate

Rodrigo Muino Tomonari requested to merge github/fork/danbev/use-isolate-instead-of-GetIsolate into master

While stepping though SetupPromises I noticed that the environments Isolate is used but not when creating the string "_setupPromises".

Is there a reason for using args.GetIsolate() instead of using the environments isolate? I see that GetIsolate() is an inline call, but could there be situations where it returns a different Isolate? If not perhaps using the local isolate variable would be a litte clearer.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Merge request reports